Feature/player model 0.12.0 #85

Merged

umpire274 merged 8 commits from feature/player-model-0.12.0 into main

2026-06-08 18:32:39 +02:00

umpire274 commented

2026-06-08 18:18:18 +02:00

(Migrated from github.com)

No description provided.

chatgpt-codex-connector[bot] (Migrated from github.com) reviewed

2026-06-08 18:21:02 +02:00

chatgpt-codex-connector[bot] (Migrated from github.com) left a comment

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e25f551b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `0e25f551b9` <details> <summary>ℹ️ About Codex in GitHub</summary> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>

src/cli/screens/db.rs

Accept legacy backup prefixes when listing restores

After upgrading from versions that created baseball_scorer_backup_* or baseball_scorer_before_restore_* files, the restore screen will no longer list those existing backups because the filter only accepts the new bs_scoring_* prefixes. Users with pre-0.12 backups in the same database directory cannot restore them through the app unless they manually rename files, so keep the old prefixes in this predicate for backward compatibility.

Useful? React with 👍 / 👎.

**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Accept legacy backup prefixes when listing restores** After upgrading from versions that created `baseball_scorer_backup_*` or `baseball_scorer_before_restore_*` files, the restore screen will no longer list those existing backups because the filter only accepts the new `bs_scoring_*` prefixes. Users with pre-0.12 backups in the same database directory cannot restore them through the app unless they manually rename files, so keep the old prefixes in this predicate for backward compatibility. Useful? React with 👍 / 👎.

src/db/player.rs

Preserve hand column order when reading players

When a player has different batting and throwing hands (for example bat = R, throw = L), this query now returns bat in column 6 and throw in column 7, but Player::from_row still interprets column 6 as throw and column 7 as bat. That makes get_by_id, get_by_team, exports, and player lists silently swap the two values after the row is read back; select throw, bat here to match the mapper.

Useful? React with 👍 / 👎.

**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Preserve hand column order when reading players** When a player has different batting and throwing hands (for example `bat = R`, `throw = L`), this query now returns `bat` in column 6 and `throw` in column 7, but `Player::from_row` still interprets column 6 as `throw` and column 7 as `bat`. That makes `get_by_id`, `get_by_team`, exports, and player lists silently swap the two values after the row is read back; select `throw, bat` here to match the mapper. Useful? React with 👍 / 👎.