feat(player-management): improve player edit/delete workflow #69

Merged

umpire274 merged 1 commit from v0.11.2 into main

2026-06-03 10:33:08 +02:00

umpire274 commented

2026-06-03 10:28:29 +02:00

(Migrated from github.com)

Add league/championship selection before team selection
Filter teams by selected league
Filter players by selected team
Keep edit/delete loop active until player selection is 0
Treat empty player selection (ENTER) as "go back"
Refresh player list after each edit or delete operation
Update changelog for v0.11.2

- Add league/championship selection before team selection - Filter teams by selected league - Filter players by selected team - Keep edit/delete loop active until player selection is 0 - Treat empty player selection (ENTER) as "go back" - Refresh player list after each edit or delete operation - Update changelog for v0.11.2

chatgpt-codex-connector[bot] (Migrated from github.com) reviewed

2026-06-03 10:30:42 +02:00

chatgpt-codex-connector[bot] (Migrated from github.com) left a comment

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e33365c3b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `e33365c3b0` <details> <summary>ℹ️ About Codex in GitHub</summary> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>

src/cli/screens/players.rs

Support league-less teams in player selection

When a player belongs to a team with league_id = NULL, the new edit/delete flow can no longer reach that player because it only lists teams returned by Team::get_by_league. This is a supported state elsewhere: team creation still offers 0. No league (src/cli/screens/team.rs:51-54), and player CSV import auto-creates teams with league_id set to None (src/cli/screens/players.rs:480-483). In those cases users who previously could edit/delete the player now see no selectable path, so this flow needs a “No league” option or another way to include unassigned teams.

Useful? React with 👍 / 👎.

**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Support league-less teams in player selection** When a player belongs to a team with `league_id = NULL`, the new edit/delete flow can no longer reach that player because it only lists teams returned by `Team::get_by_league`. This is a supported state elsewhere: team creation still offers `0. No league` (`src/cli/screens/team.rs:51-54`), and player CSV import auto-creates teams with `league_id` set to `None` (`src/cli/screens/players.rs:480-483`). In those cases users who previously could edit/delete the player now see no selectable path, so this flow needs a “No league” option or another way to include unassigned teams. Useful? React with 👍 / 👎.