V0.11.0 alpha2 fix codex #65

Merged

umpire274 merged 6 commits from v0.11.0-alpha2-fix_codex into main

2026-04-21 00:52:26 +02:00

umpire274 commented

2026-04-21 00:43:45 +02:00

(Migrated from github.com)

No description provided.

chatgpt-codex-connector[bot] (Migrated from github.com) reviewed

2026-04-21 00:46:21 +02:00

chatgpt-codex-connector[bot] (Migrated from github.com) left a comment

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34643ded7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `34643ded7c` <details> <summary>ℹ️ About Codex in GitHub</summary> [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>

src/engine/play_ball.rs

Use movement half when crediting steal-home runs

add_runs_to_score(state, 1) credits runs using state.half/state.inning, but replay links steals to the previous committed PA (rm.pa_seq = last_pa_seq in play_ball.rs), so a steal during the first in-progress at-bat of a new half can be replayed while state.half is still the prior half. In that case, this line assigns the run to the wrong team/inning bucket instead of the row’s recorded rm.half_inning, which regresses resume accuracy for steal-home events across half-inning boundaries.

Useful? React with 👍 / 👎.

**![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat) Use movement half when crediting steal-home runs** `add_runs_to_score(state, 1)` credits runs using `state.half/state.inning`, but replay links steals to the previous committed PA (`rm.pa_seq = last_pa_seq` in `play_ball.rs`), so a steal during the first in-progress at-bat of a new half can be replayed while `state.half` is still the prior half. In that case, this line assigns the run to the wrong team/inning bucket instead of the row’s recorded `rm.half_inning`, which regresses resume accuracy for steal-home events across half-inning boundaries. Useful? React with 👍 / 👎.