Preserve hand column order when reading players #86

New issue

Closed

opened 2026-06-08 18:33:18 +02:00 by umpire274 · 0 comments

umpire274 commented

2026-06-08 18:33:18 +02:00

(Migrated from github.com)

Preserve hand column order when reading players

When a player has different batting and throwing hands (for example bat = R, throw = L), this query now returns bat in column 6 and throw in column 7, but Player::from_row still interprets column 6 as throw and column 7 as bat. That makes get_by_id, get_by_team, exports, and player lists silently swap the two values after the row is read back; select throw, bat here to match the mapper.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/85#discussion_r3374763707

**Preserve hand column order when reading players** When a player has different batting and throwing hands (for example `bat = R`, `throw = L`), this query now returns `bat` in column 6 and `throw` in column 7, but `Player::from_row` still interprets column 6 as `throw` and column 7 as `bat`. That makes `get_by_id`, `get_by_team`, exports, and player lists silently swap the two values after the row is read back; select `throw, bat` here to match the mapper. Useful? React with 👍 / 👎. _Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/85#discussion_r3374763707_