Exclude hit and walk rows from composite replay pass #62

New issue

Closed

opened 2026-04-20 23:37:07 +02:00 by umpire274 · 0 comments

umpire274 commented

2026-04-20 23:37:07 +02:00

(Migrated from github.com)

Exclude hit and walk rows from composite replay pass

run_play_ball_engine now classifies every non-"steal" runner_movements row as composite_movements, and replay_plate_appearances_and_log applies all of them through apply_composite_state. That unintentionally re-applies normal PA movements ("walk", "hit_auto", "hit_override") that were already applied by apply_plate_appearance_row, so resumed games can double-count scoring movements (especially rows ending at HOME) and corrupt replayed state.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/61#discussion_r3113807288

**Exclude hit and walk rows from composite replay pass** `run_play_ball_engine` now classifies every non-`"steal"` `runner_movements` row as `composite_movements`, and `replay_plate_appearances_and_log` applies all of them through `apply_composite_state`. That unintentionally re-applies normal PA movements (`"walk"`, `"hit_auto"`, `"hit_override"`) that were already applied by `apply_plate_appearance_row`, so resumed games can double-count scoring movements (especially rows ending at `HOME`) and corrupt replayed state. Useful? React with 👍 / 👎. _Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/61#discussion_r3113807288_