Reject steals when action segments are present #59

New issue

Closed

opened 2026-04-20 16:54:06 +02:00 by umpire274 · 0 comments

umpire274 commented

2026-04-20 16:54:06 +02:00

(Migrated from github.com)

Reject steals when action segments are present

check_mixing only errors on has_pitch && has_non_steal_action, so lines that mix steals with hits/outs/FC (for example 5 h, 3 st 2b) are accepted even though this combination is unsupported in the new grammar. Once accepted, build_commands still emits both commands (steal plus hit/defensive play), which can apply extra runner movement in the same plate appearance and produce incorrect scoring state instead of a validation error. Please add an explicit steal-vs-action exclusion in the mixing pass.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/58#discussion_r3111521197

**Reject steals when action segments are present** `check_mixing` only errors on `has_pitch && has_non_steal_action`, so lines that mix steals with hits/outs/FC (for example `5 h, 3 st 2b`) are accepted even though this combination is unsupported in the new grammar. Once accepted, `build_commands` still emits both commands (steal plus hit/defensive play), which can apply extra runner movement in the same plate appearance and produce incorrect scoring state instead of a validation error. Please add an explicit steal-vs-action exclusion in the mixing pass. Useful? React with 👍 / 👎. _Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/58#discussion_r3111521197_