Apply runner segments when replaying fielder's choice PAs #55

New issue

Closed

opened 2026-04-16 18:22:46 +02:00 by umpire274 · 0 comments

umpire274 commented

2026-04-16 18:22:46 +02:00

(Migrated from github.com)

** Apply runner segments when replaying fielder's choice PAs**

This branch reconstructs FieldersChoice by updating only outs and apply_batter_fielders_choice, but composed defensive plays can also include explicit runner outs/advances (persisted as runner-movement rows in apply_defensive_play_command). Because those runner segments are not applied here, commands like 9 64, 1 o6 1b leave runners on incorrect bases after live apply/resume, causing state drift from what was scored and persisted.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/54#discussion_r3094656034

** Apply runner segments when replaying fielder's choice PAs** This branch reconstructs `FieldersChoice` by updating only `outs` and `apply_batter_fielders_choice`, but composed defensive plays can also include explicit runner outs/advances (persisted as runner-movement rows in `apply_defensive_play_command`). Because those runner segments are not applied here, commands like `9 64, 1 o6 1b` leave runners on incorrect bases after live apply/resume, causing state drift from what was scored and persisted. Useful? React with 👍 / 👎. _Originally posted by @chatgpt-codex-connector[bot] in https://github.com/umpire274/bs_scoring/pull/54#discussion_r3094656034_